feat: Implementation of Chromium driver plus capabilities#2003
Merged
mykola-mokhnach merged 8 commits intoappium:masterfrom Sep 8, 2023
Merged
feat: Implementation of Chromium driver plus capabilities#2003mykola-mokhnach merged 8 commits intoappium:masterfrom
mykola-mokhnach merged 8 commits intoappium:masterfrom
Conversation
AlessandroMiccoli
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
AlessandroMiccoli
changed the title
src/main/java/io/appium/java_client/chromium/options/ChromiumOptions.java
Show resolved
Hide resolved
Contributor
|
It looks like linter is not very happy. Please check the job results above |
src/test/java/io/appium/java_client/drivers/options/OptionsBuildingTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/appium/java_client/drivers/options/OptionsBuildingTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
Please rebase with master. I have fixed several tests that were failing before |
…d errors, such as indentation.
Contributor
Author
|
I made the changes. Please, could you answer the question here: ISSUE_1995? I am not sure if I need to add the goog options |
Contributor
replied |
mykola-mokhnach
approved these changes
Sep 7, 2023
SrinivasanTarget
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Please provide briefly described change list which are you going to propose.
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
The following are implemented: