test: Align Selenium version in test dependencies#2042
test: Align Selenium version in test dependencies#2042valfirst merged 1 commit intoappium:masterfrom
Conversation
valfirst
requested review from
SrinivasanTarget,
mykola-mokhnach and
saikrishna321
as code owners
| exclude group: 'org.seleniumhq.selenium' | ||
| } | ||
| testImplementation platform(group: 'org.seleniumhq.selenium', name: 'selenium-bom', version: '4.13.0') | ||
| testImplementation platform(group: 'org.seleniumhq.selenium', name: 'selenium-bom', version: '4.14.1') |
There was a problem hiding this comment.
why we cannot use ${seleniumVersion} template there?
There was a problem hiding this comment.
For now it doesn't matter which form of version to put, because we stick to the latest version (4.14.1) everywhere. But once new version of Selenium is released, @dependabot will pick it up and open PR with update of the version in test dependencies. In this way CI tests will be run against the latest Selenium client, if any compatibility issue appear, we'll detect it immediately.
There was a problem hiding this comment.
why this time there was no PR from dependabot?
There was a problem hiding this comment.
@depenabot is run by schedule (https://github.com/appium/java-client/blob/master/.github/dependabot.yml#L3-L8): once a week (on Monday) for this repo. Or it can be triggered manually.
There was a problem hiding this comment.
I assume triggering it manually would still save more time in comparison to a custom PR creation
3 participants
Change list
Align Selenium version in test dependencies.
Types of changes
What types of changes are you proposing/introducing to Java client?