feat: add support for FlutterAndroidDriver#2203
Merged
SrinivasanTarget merged 16 commits intoappium:masterfrom Jul 23, 2024
Merged
feat: add support for FlutterAndroidDriver#2203SrinivasanTarget merged 16 commits intoappium:masterfrom
SrinivasanTarget merged 16 commits intoappium:masterfrom
Conversation
src/e2eFlutterTest/java/io/appium/java_client/android/BaseFlutterTest.java
Show resolved
Hide resolved
src/main/java/io/appium/java_client/flutter/commands/ScrollParameter.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/flutter/commands/WaitParameter.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/flutter/commands/WaitParameter.java
Outdated
Show resolved
Hide resolved
valfirst
requested changes
Jul 22, 2024
src/e2eFlutterTest/java/io/appium/java_client/android/BaseFlutterTest.java
Outdated
Show resolved
Hide resolved
src/e2eFlutterTest/java/io/appium/java_client/android/CommandTest.java
Outdated
Show resolved
Hide resolved
| * @return an instance of {@link AppiumBy.ByFlutterKey} | ||
| */ | ||
| public static By flutterKey(final String selector) { | ||
| public static FlutterBy flutterKey(final String selector) { |
Collaborator
There was a problem hiding this comment.
why are these changes needed?
Contributor
Author
There was a problem hiding this comment.
Currenlty all flutter script can only work with locators supported by flutter driver. This change is specifically introduced the simplify the API consumption and to prevent the manual type casting when calling the commands.
driver.waitForInVisible(new WaitParameter().setLocator(AppiumBy.flutterKey("message_field")));Instead of
driver.waitForInVisible(new WaitParameter().setLocator((AppiumBy.FlutterBy)AppiumBy.flutterKey("message_field")));
src/e2eFlutterTest/java/io/appium/java_client/android/BaseFlutterTest.java
Outdated
Show resolved
Hide resolved
src/e2eFlutterTest/java/io/appium/java_client/android/BaseFlutterTest.java
Outdated
Show resolved
Hide resolved
src/e2eFlutterTest/java/io/appium/java_client/android/CommandTest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/flutter/commands/ScrollParameter.java
Outdated
Show resolved
Hide resolved
mykola-mokhnach
approved these changes
Jul 22, 2024
valfirst
approved these changes
Jul 22, 2024
SrinivasanTarget
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub