fix python3 set_clipboard error#267
Merged
KazuCocoa merged 2 commits intoappium:masterfrom Oct 31, 2018
Merged
Conversation
| """ | ||
| self.set_clipboard(bytes(text.encode('UTF-8')), ClipboardContentType.PLAINTEXT, label) | ||
|
|
||
| def _bytes(value, encoding): |
Contributor
There was a problem hiding this comment.
does it make sense to put this helper method into some separate helper module?
Member
Author
There was a problem hiding this comment.
I thought so, but nothing method used bytes so far. I'd like to extract here in next time.
mykola-mokhnach
approved these changes
Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3 requires encoding in
bytes. Python 2 doesn't.close #265
Python 3
Python 2