Skip to content

Fix to enable appium ruby console (arc) on windows; #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bootstraponline merged 1 commit into from
Feb 20, 2014
Merged

Fix to enable appium ruby console (arc) on windows; #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions lib/appium_lib/driver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,6 @@ def update data, *args
'APP_ACTIVITY', 'APP_WAIT_ACTIVITY',
'DEVICE'

# Ensure app path is absolute
ENV['APP_PATH'] = File.expand_path ENV['APP_PATH'] if ENV['APP_PATH'] &&
!ENV['APP_PATH'].empty?

# device is not case sensitive
ENV['DEVICE'] = ENV['DEVICE'].strip.downcase if !ENV['DEVICE'].nil?
if ! %w(ios android selendroid).include? ENV['DEVICE']
Expand Down Expand Up @@ -429,14 +425,11 @@ def absolute_app_path
# Sauce storage API. http://saucelabs.com/docs/rest#storage
return @app_path if @app_path.start_with? 'sauce-storage:'
return @app_path if @app_path.match(/^http/) # public URL for Sauce
if @app_path.match(/^\//) # absolute file path
if @app_path.match(/^(\/|[a-zA-Z]:)/) # absolute file path
raise "App doesn't exist. #{@app_path}" unless File.exist? @app_path
return @app_path
end

# if it starts with [A-Z]:\ then it's a windows absolute path
return @app_path if @app_path.match(/^[a-zA-Z]:\\/)

# if it doesn't contain a slash then it's a bundle id
return @app_path unless @app_path.match(/[\/\\]/)

Expand Down