Add dry run option to CLI #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czechboy0
reviewed
Jul 17, 2023
czechboy0
reviewed
Jul 17, 2023
czechboy0
requested changes
Jul 17, 2023
Contributor
czechboy0
left a comment
czechboy0
left a comment
There was a problem hiding this comment.
Looks great, thanks! Just requested that we split the output color changes into a separate PR, and one other suggestion.
czechboy0
requested changes
Jul 17, 2023
Contributor
czechboy0
left a comment
czechboy0
left a comment
There was a problem hiding this comment.
Two more minor requests, thanks.
simonjbeaumont
requested changes
Jul 19, 2023
czechboy0
reviewed
Jul 19, 2023
simonjbeaumont
approved these changes
Jul 20, 2023
czechboy0
requested changes
Jul 20, 2023
Contributor
czechboy0
left a comment
czechboy0
left a comment
There was a problem hiding this comment.
One last request, otherwise lgtm.
Contributor
|
@denil-ct Unfortunately #98 touched similar code as your PR, so there are a few conflicts you'll need to resolve before landing. Once that's all green, and #123 (comment) is addressed, we can land it. |
…rator into dry-run-cli # Conflicts: # Sources/swift-openapi-generator/GenerateCommand.swift # Sources/swift-openapi-generator/GenerateOptions+runGenerator.swift # Sources/swift-openapi-generator/runGenerator.swift
czechboy0
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #27
Modifications
Add a dry run option to CLI
--dry-runResult
If passed, the changes would be printed to terminal, without actually affecting the file system.
Test Plan
Manually tested with various input combinations.