Skip to content

Conversation

@estherjsuh
Copy link
Contributor

@estherjsuh estherjsuh commented May 4, 2021

Task RED-2075

@OmarIthawi
Copy link
Contributor

Thanks @estherjsuh! The tests are now failing because django-waffle wasn't added to the requirements:

    module = import_module(entry)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
ImportError: No module named waffle
ERROR: InvocationError for command /home/runner/work/figures/figures/.tox/py27-ginkgo/bin/pytest -c pytest-ginkgo.ini (exited with code 1)

Please fix that and it should be good to make the tests passes.

@OmarIthawi
Copy link
Contributor

@estherjsuh I see that Juniper tests passes which is great. Please downgrade the django-waffle for both Ginkgo and Hawthorn.

@OmarIthawi OmarIthawi self-requested a review May 17, 2021 07:10
Copy link
Contributor

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some fixes

Copy link
Contributor

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try django_db mark

Copy link
Contributor

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! Test passes and the code looks great to me.

Thanks @estherjsuh!

I'll wait for John to review it because we're both new to this code.

@estherjsuh estherjsuh force-pushed the esther/test-commit branch 2 times, most recently from 7b223af to 3dcc760 Compare May 19, 2021 15:52
@estherjsuh estherjsuh requested a review from johnbaldwin May 19, 2021 15:52
@OmarIthawi OmarIthawi changed the title Esther/test commit add waffle swtich to disable tasks for maintenance May 19, 2021
@estherjsuh estherjsuh changed the title add waffle swtich to disable tasks for maintenance add waffle switch to disable tasks for maintenance May 19, 2021
Copy link
Contributor

@johnbaldwin johnbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @estherjsuh Great work! All my inline comments are on styling. Minor things, but if you would address those please.

You will need to merge from master into this PR branch

Thanks!

@estherjsuh estherjsuh force-pushed the esther/test-commit branch from 3f22146 to fe6c131 Compare May 27, 2021 18:58
@estherjsuh estherjsuh requested a review from johnbaldwin May 27, 2021 19:13
@estherjsuh
Copy link
Contributor Author

@johnbaldwin Thank you for the review! I made the suggested changes, and I will merge once you have a final pass at it.

Copy link
Contributor

@johnbaldwin johnbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @estherjsuh ! Ship it!

@estherjsuh estherjsuh merged commit 035f9ca into master May 27, 2021
@estherjsuh estherjsuh deleted the esther/test-commit branch May 27, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants