-
Notifications
You must be signed in to change notification settings - Fork 38
add waffle switch to disable tasks for maintenance #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @estherjsuh! The tests are now failing because Please fix that and it should be good to make the tests passes. |
|
@estherjsuh I see that Juniper tests passes which is great. Please downgrade the |
OmarIthawi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some fixes
OmarIthawi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try django_db mark
OmarIthawi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great! Test passes and the code looks great to me.
Thanks @estherjsuh!
I'll wait for John to review it because we're both new to this code.
7b223af to
3dcc760
Compare
johnbaldwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @estherjsuh Great work! All my inline comments are on styling. Minor things, but if you would address those please.
You will need to merge from master into this PR branch
Thanks!
apply changes from code review
3f22146 to
fe6c131
Compare
|
@johnbaldwin Thank you for the review! I made the suggested changes, and I will merge once you have a final pass at it. |
johnbaldwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @estherjsuh ! Ship it!
Task RED-2075