Skip to content

🐛 Trying to fix an issue witj GINKGO #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OmarIthawi merged 1 commit into from
Feb 17, 2022
Merged

🐛 Trying to fix an issue witj GINKGO #423

OmarIthawi merged 1 commit into from
Feb 17, 2022

Conversation

@OmarIthawi
Copy link
Contributor

@OmarIthawi OmarIthawi commented Feb 16, 2022 •
edited
Loading

Duplicates:

@johnbaldwin I don't intend to test this, so please take a quick action of merging or closing this PR unmerged.

@OmarIthawi OmarIthawi mentioned this pull request Feb 16, 2022
Closed
johnbaldwin
johnbaldwin approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@johnbaldwin johnbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Omar!

@OmarIthawi OmarIthawi merged commit 9856174 into main Feb 17, 2022
@OmarIthawi OmarIthawi deleted the cp-ponytojas-ginkgo-fix branch February 17, 2022 05:10
@johnbaldwin
Copy link
Contributor

johnbaldwin commented Mar 1, 2022

@OmarIthawi Just FYI I need to revert this. In Ginkgo, the namespace IS courseware so I need to revert this PR. On a production Ginkgo site:

>>> from django.conf import settings
>>> [rec for rec in settings.INSTALLED_APPS if 'courseware' in rec]
['courseware']

@johnbaldwin johnbaldwin mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shadinaif shadinaif Awaiting requested review from shadinaif

@estherjsuh estherjsuh Awaiting requested review from estherjsuh

@bryanlandia bryanlandia Awaiting requested review from bryanlandia

2 more reviewers

@johnbaldwin johnbaldwin johnbaldwin approved these changes

@melvinsoft melvinsoft melvinsoft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@OmarIthawi @johnbaldwin @melvinsoft @ponytojas