Cleanup deprecated and empty pipeline code #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In `figures.pipeline.course_daily_metrics`, `get_average_progress_deprecated` wasn't called by anyone, so removed it * Removing this means we can remove `figures.pipeline.loaders`, so removed that too * Removed the tests for the deprecated code
* the figures.pipeline `extractors` and `transformers` were part of the original 'ETL' context. However after all this time, Figures hadn't needed these. So now they are gone
johnbaldwin
requested review from
OmarIthawi,
bryanlandia,
estherjsuh,
melvinsoft and
shadinaif
as code owners
OmarIthawi
approved these changes
Mar 7, 2022
Contributor
|
@johnbaldwin tests aren't running. Would you mind double checking on the issue? |
Contributor
Author
That's why I made this PR :) #442 |
OmarIthawi
approved these changes
Mar 7, 2022
Contributor
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
tests are running! thanks john.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated code in course daily metrics
In
figures.pipeline.course_daily_metrics,get_average_progress_deprecatedwasn't called by anyone, so removed itfigures.pipeline.loaders, so removed that tooRemoved empty
figures.pipelinemodulesextractorsandtransformerswere part of the original 'ETL' context. However after all this time, Figures hadn't needed these. So now they are gone