Test var id attribute #10243
Merged
Test var id attribute #10243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-var-id-attribute # Conflicts: # composer.json # composer.lock
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
composer.json (1)
55-55: Switching to a dev branch alias is risky—pin to a commit or keep the stable tag.Replacing
0.74.*withdev-primary-attribute as 0.73.2silently downgrades the library while pointing to an unfrozen development branch.
Potential fallout:
• Loss of fixes/features added in 0.74.x.
• Builds become non-deterministic whenever the branch moves.
• Security tooling may miss the real version in use.Strongly recommend one of:
- "utopia-php/database": "dev-primary-attribute as 0.73.2", + # Option A – pin the exact commit + "utopia-php/database": "dev-primary-attribute#<commit-sha> as 0.73.2", + # Option B – stay on the stable line until the feature is tagged + "utopia-php/database": "0.74.*",Please confirm no 0.74-only APIs are used elsewhere and that CI covers this downgrade.
If the branch must stay, lock it to a commit to keep reproducible builds.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
composer.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
- GitHub Check: Benchmark
- GitHub Check: E2E Shared Mode Service Test (VCS, Shared V1)
- GitHub Check: E2E Shared Mode Service Test (Messaging, Shared V2)
- GitHub Check: E2E Shared Mode Service Test (Realtime, Shared V2)
- GitHub Check: E2E Shared Mode Service Test (Proxy, Shared V1)
- GitHub Check: E2E Shared Mode Service Test (Projects, Shared V2)
- GitHub Check: E2E Shared Mode Service Test (Locale, Shared V2)
- GitHub Check: E2E Shared Mode Service Test (Sites, Shared V2)
- GitHub Check: E2E Shared Mode Service Test (Databases/Grids, Shared V2)
- GitHub Check: E2E Shared Mode Service Test (Account, Shared V1)
- GitHub Check: E2E Shared Mode Service Test (Sites, Shared V1)
- GitHub Check: E2E Shared Mode Service Test (FunctionsSchedule, Shared V2)
- GitHub Check: E2E Shared Mode Service Test (Databases/Legacy, Shared V2)
- GitHub Check: E2E Shared Mode Service Test (Avatars, Shared V2)
- GitHub Check: E2E Shared Mode Service Test (Functions, Shared V1)
- GitHub Check: E2E Shared Mode Service Test (Account, Shared V2)
- GitHub Check: E2E Service Test (FunctionsSchedule)
- GitHub Check: E2E Service Test (Databases/Grids)
- GitHub Check: E2E Service Test (Databases/Legacy)
…t-var-id-attribute # Conflicts: # composer.lock
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
✨ Benchmark results
⚡ Benchmark Comparison
|
Contributor
📝 WalkthroughWalkthroughThe changes update the version constraint for the "utopia-php/database" dependency in composer.json from "0.74." to "0.75.". In two PHP source files related to deployment duplication for functions and sites, the code now removes the '$sequence' attribute from deployment data before creating new deployment documents, instead of explicitly setting '$sequence' to an empty string. No changes were made to public entity declarations. Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
fogelito
commented
Aug 4, 2025
abnegate
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
https://github.com/utopia-php/database/compare/0.74.3..0.75.2
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist