Update errors.php #5136
Closed
Update errors.php #5136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@stnguyen90 Please review this |
stnguyen90
requested changes
Mar 14, 2023
Contributor
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Great PR! 🤯 We left some comments during the review, please check them out.
|
|
||
| public function testCreateProjectDomain($data): array | ||
| { | ||
| $id = $data['projectId'] ?? ''; |
Contributor
There was a problem hiding this comment.
Looks like there are style problems indicated by the lint errors. Would you please fix them so the CI job passes?
Contributor
|
@vedant-z, would you please run the formatter to fix the styling errors? FYI, I'll need to close this due to inactivity soon. |
Contributor
|
Closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4519
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist