Skip to content

Conversation

@Emiliaaah
Copy link

@Emiliaaah Emiliaaah commented Apr 17, 2023

What does this PR do?

This PR aims to update some images that should probably be updated once in a while.

The main reason for this PR is that I discovered that traefik was running on v2.7 which has a critical CVE(-2022-37434)

Test Plan

I updated the images in the docker-compose file and then played around a bit with the web-ui which still seemed to work fine.

Related PRs and Issues

  • None

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Changes

  • Update traefik
  • Update telegraf
  • Update redis
  • Update influxdb?

@Emiliaaah
Copy link
Author

I'm curious as to why we've chosen to use a custom influxdb image instead of using the official one. Like these one's I'd like for the image to be updated, but since I don't know the reasoning behind it I left it alone for now. If anyone could let me know though we could discuss adding any changes to this PR.

Updated the traefik image version check to 2.9
@christyjacob4
Copy link
Contributor

@Emiliaaah The main reason we used a custom docker image for influx is such that we could initialise it with our own startup scripts.

  1. https://github.com/appwrite/docker-influxdb/blob/main/init-influxdb.sh
  2. https://github.com/appwrite/docker-influxdb/blob/main/influxdb.conf
  3. https://github.com/appwrite/docker-influxdb/blob/main/entrypoint.sh

However we are soon deprecating influx from our stack as we will be storing the usage data in our main MariaDB itself.

@Emiliaaah
Copy link
Author

@christyjacob4 Ah okay, that makes sense. I'll let influxdb stay the way it is then.

Something about this PR though, since it's been a while since these images have been updated, it might be a good idea to check the possibility of upgrading to newer versions every once in a while or say, every release, etc. as long as there is some check in place so we don't suddenly end up with 3 year old images.

@Emiliaaah Emiliaaah marked this pull request as ready for review April 20, 2023 19:16
@stnguyen90 stnguyen90 requested a review from christyjacob4 June 23, 2023 01:25
@Emiliaaah Emiliaaah closed this by deleting the head repository Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants