Fix audit user internal #5809
Closed
Fix audit user internal #5809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's important to use userInternalId so that if a user is recreated with the same ID, lookups for the user will not return the data of the old deleted user. We will still store userId in data so that it can be pulled out and returned for the log API calls.
The audit userId is actually the internal id and the user id is in the data attribute.
The userId in audit is actually the userInternalId.
1. Remove the userInternalId attribute 2. Replace userId in audit documents with userInternalId and put userId in data
stnguyen90
force-pushed
the
fix-audit-userInternalId
branch
from
1bc3deb to
26334b7
Compare
eldadfux
approved these changes
Jul 13, 2023
Contributor
Author
|
@TorstenDittmann would you please look at this when you get a chance? |
eldadfux
approved these changes
Jul 17, 2023
TorstenDittmann
approved these changes
Jul 18, 2023
Contributor
Author
|
This has a merge conflict because it's based on 1.3.7 rather than 1.3.x. 1.3.8 has been released based branch fix-audit-userInternalId. This won't be merged into 1.3.x. Instead, #5847 has been created to update master for the future. |
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In 1.3.x, the audit activity stopped working for existing projects because there was a userInternalId attribute added to the audit collections, but there was no migration to add the attribute.
In later versions of the audit library, we removed the userInternalId attribute, so this PR bumps Appwrite to use that version. In addition, this PR also updates Appwrite to user the userInternalId for the audit userId so that if a user is recreated with the same ID, the audit data for the previous user isn't linked to the new user.
Fixes: #5805
Test Plan
E2E Tests
Passed locally:
Manual Tests
Successful Migration
Audit Activity Created After Migration
Related PRs and Issues
Checklist