Skip to content

Conversation

@btme0011
Copy link
Contributor

@btme0011 btme0011 commented Sep 3, 2023

What does this PR do?

Implemented validation checks for the name, email, and password fields. If any of these validations fail, an exception is thrown and the corresponding error message is displayed to the user.

Test Plan

Before changes
We were able to create empty users

After changes
Screenshot 2023-09-03 at 11 08 51 AM

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@eldadfux
Copy link
Member

eldadfux commented Sep 3, 2023

@btme0011 we appreciate the effort and contribution, but this is the expected behavior. All this details are optional to allow you to simulate different type of users through different login methods (email+password, phone, magic URL, anonymous and more).

It is always best to open an issue and discuss before investing time in making a PR. That said, great job with the code implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants