Skip to content

Conversation

@Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Jan 2, 2024

What does this PR do?

Implements 256 chars max password length.

Passwords hashed with Argon2 should be safe no matter the length, but it always make sense to have reasonable limit - for performance, if nothing else.

Test Plan

  • New tests added

Related PRs and Issues

x

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@eldadfux eldadfux merged commit 31e23a3 into 1.5.x Jan 2, 2024
@stnguyen90 stnguyen90 deleted the feat-max-password-length branch January 2, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants