Update assistant to not crash on startup. #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TGlide
approved these changes
Sep 20, 2023
stnguyen90
force-pushed
the
fix-missing-key
branch
from
6dcb179 to
cf0808d
Compare
TGlide
approved these changes
Sep 20, 2023
main.js
Outdated
| app.listen(port, () => { | ||
| app.listen(port, async () => { | ||
| console.log(`Started server on port: ${port}`); | ||
| console.log('initializing search index...'); |
Contributor
There was a problem hiding this comment.
I think still a typo with lowercase i
TorstenDittmann
approved these changes
Sep 21, 2023
If the _APP_ASSISTANT_OPENAI_API_KEY env var was not set, the assistant would crash. This prevents that from happening and returns an error message if the key is not set.
stnguyen90
force-pushed
the
fix-missing-key
branch
from
cf0808d to
905eac6
Compare
2 tasks
TorstenDittmann
approved these changes
Sep 23, 2023
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If the _APP_ASSISTANT_OPENAI_API_KEY env var was not set, the assistant would crash. This prevents that from happening and returns an error message if the key is not set.
Test Plan
With valid _APP_ASSISTANT_OPENAI_API_KEY set
Logs:
Request:
With invalid _APP_ASSISTANT_OPENAI_API_KEY set
Logs:
...
Request:
Without _APP_ASSISTANT_OPENAI_API_KEY set
Logs:
Request:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes