feat: perf #36
Merged
feat: perf #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
loks0n
commented
Oct 27, 2023
| mangle: false, | ||
| headerIds: false, | ||
| }); | ||
| const html = marked(project.description); |
Member
Author
There was a problem hiding this comment.
These are false by default now.
loks0n
commented
Oct 30, 2023
Comment on lines
10
to
+19
| rollupOptions: { | ||
| input: ['src/entry.vercel-edge.tsx', '@qwik-city-plan'], | ||
| external: ['util'], | ||
| }, | ||
| outDir: '.vercel/output/functions/_qwik-city.func', | ||
| }, | ||
| plugins: [vercelEdgeAdapter()], | ||
| ssr: { | ||
| noExternal: true, | ||
| }, | ||
| plugins: [vercelEdgeAdapter(), viteNodePolyfills()], |
Member
Author
There was a problem hiding this comment.
Vercel Functions does not have util module. We have to polyfill it.
TorstenDittmann
left a comment
TorstenDittmann
left a comment
There was a problem hiding this comment.
some questions.
Unrelated, we could use https://vercel.com/storage/blob to make the image proxy even faster 👍🏻
Meldiron
approved these changes
Oct 30, 2023
Contributor
Meldiron
left a comment
Meldiron
left a comment
There was a problem hiding this comment.
LGTM. If you have some performance numbers about before and after (build / init load / ...), pls attach to PR.
TorstenDittmann
approved these changes
Oct 30, 2023
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some performance issues