Feat: empty arrays UI #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
TorstenDittmann
requested changes
Jan 10, 2023
Contributor
TorstenDittmann
left a comment
TorstenDittmann
left a comment
There was a problem hiding this comment.
the Add item button is not vertically aligned with the attribute name 👍🏻
Contributor
Author
I can't seem to reproduce: Any particular steps you went through? |
feat: display attribute types on input fields
...tes/console/project-[project]/databases/database-[database]/collection-[collection]/store.ts
Outdated
Show resolved
Hide resolved
...roject-[project]/databases/database-[database]/collection-[collection]/[[page]]/+page.svelte
Outdated
Show resolved
Hide resolved
...roject-[project]/databases/database-[database]/collection-[collection]/[[page]]/+page.svelte
Outdated
Show resolved
Hide resolved
TorstenDittmann
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates an AttributeForm component, that substitutes the forms on create document and update document. This component also changes the logic of array fields, allowing documents with empty array attributes to be created.
Test Plan
Manual
Related PRs and Issues
N/A
Have you read the Contributing Guidelines on issues?
Yes