feat: set default type of datetime to null #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ArmanNik
reviewed
Jan 16, 2023
Comment on lines
+42
to
+44
| if (value === '') { | ||
| value = null; | ||
| } |
Contributor
There was a problem hiding this comment.
I don't think there is any difference, but is there a reason why we handle it like this instead of doing
$: if(!value){
value = null
}
Contributor
Author
There was a problem hiding this comment.
@ArmanNik I tried it, but on doing this, for some reason the update button stops working. It does not detect a change in the input field that way
Screen.Recording.2023-01-16.at.9.04.41.PM.mov
Contributor
There was a problem hiding this comment.
Ahaahahahah got it 💪 that's a very weird behavior 😆
Contributor
Author
|
I tried to fix this issue as well where URL attributes show up as string in the UI, and I realised that the API response is structured that way.
|
ArmanNik
approved these changes
Jan 16, 2023
TorstenDittmann
approved these changes
Jan 27, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before
Screen.Recording.2023-01-16.at.11.54.51.AM.mov
After
Screen.Recording.2023-01-16.at.11.55.20.AM.mov
Before
Screen.Recording.2023-01-16.at.7.43.45.PM.mov
After
Screen.Recording.2023-01-16.at.7.42.49.PM.mov
Test Plan
Existing tests
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)