fix: column width for sessions and activity table for smaller devices #2745
+46
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Console (appwrite/console)Project ID: Tip Every Git commit and branch gets its own deployment URL automatically |
Contributor
WalkthroughTwo session management pages have their table column definitions updated to use responsive min-width objects instead of fixed pixel widths for the client, location, and ip columns. The action column width remains unchanged at 100. No logic or control flow modifications are present. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ItzNotABug
requested changes
Dec 29, 2025
Comment on lines
17
to
38
| const columns: PinkColumn[] = [ | ||
| { id: 'user', ...(insideSideSheet ? { width: 140 } : {}) }, | ||
| { id: 'event', ...(insideSideSheet ? { width: 125 } : {}) }, | ||
| { id: 'location', ...(insideSideSheet ? { width: 100 } : {}) }, | ||
| { id: 'ip', ...(insideSideSheet ? { width: { min: 150 } } : {}) }, | ||
| { id: 'date', ...(insideSideSheet ? { width: { min: 200 } } : {}) } | ||
| { | ||
| id: 'user', | ||
| ...(insideSideSheet ? { width: 140 } : { width: { min: 100 } }) | ||
| }, | ||
| { | ||
| id: 'event', | ||
| ...(insideSideSheet ? { width: 125 } : { width: { min: 160 } }) | ||
| }, | ||
| { | ||
| id: 'location', | ||
| ...(insideSideSheet ? { width: 100 } : { width: { min: 120 } }) | ||
| }, | ||
| { | ||
| id: 'ip', | ||
| ...(insideSideSheet ? { width: { min: 150 } } : { width: { min: 250 } }) | ||
| }, | ||
| { | ||
| id: 'date', | ||
| ...(insideSideSheet ? { width: { min: 200 } } : { width: { min: 180 } }) | ||
| } | ||
| ]; |
Member
There was a problem hiding this comment.
lets make a method to return values based on the if/else check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before
After
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.