feat: add password personal data check #405
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/routes/console/project-[project]/auth/security/updatePasswordPersonalData.svelte
Outdated
Show resolved
Hide resolved
src/routes/console/project-[project]/auth/security/updatePasswordPersonalData.svelte
Outdated
Show resolved
Hide resolved
…low-personal-data
…low-personal-data
src/routes/console/project-[project]/auth/security/updatePersonalDataCheck.svelte
Outdated
Show resolved
Hide resolved
| import type { BarSeriesOption } from 'echarts/charts'; | ||
|
|
||
| export const project = derived(page, ($page) => $page.data.project as Models.Project); | ||
| export const project = derived(page, ($page) => $page.data.project as Models.Project | any); |
There was a problem hiding this comment.
Why does it need the any? 🤔 and if it's really necessary would it work with unknown?
There was a problem hiding this comment.
We don't have the new project model which has the disallowPersonalData attribute since we are not using the generated SDK yet.
@TorstenDittmann asked me to patch it up this way and have all the changes in one single branch ( main ) in this case and he'd generate & release a new console sdk after all changes are in there
| async function updatePersonalDataCheck() { | ||
| try { | ||
| const path = '/projects/' + $project.$id + '/auth/personal-data'; | ||
| await sdk.forConsole.client.call( |
There was a problem hiding this comment.
Are there any plans to add this to the SDK?
There was a problem hiding this comment.
@ArmanNik yes, Torsten said we'd do it once all the changes for 1.4 are merged.
…llow-personal-data
What does this PR do?
Adds support for disallowing personal data in passwords
Screen.Recording.2023-04-15.at.2.15.16.PM.mov
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)