Update description for user email, phone, and preferences #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stnguyen90
changed the title
eldadfux
requested changes
Jul 27, 2023
Member
eldadfux
left a comment
eldadfux
left a comment
There was a problem hiding this comment.
Let's drop the usage of the tags. It will be very difficult for us to decide when and when not use them.
| <Form onSubmit={updateEmail}> | ||
| <CardGrid> | ||
| <Heading tag="h6" size="7">Email</Heading> | ||
| <p>Update user's email. An Email should be formatted as: <b>name@example.com.</b></p> |
Member
There was a problem hiding this comment.
Suggested change
| <p>Update user's email. An Email should be formatted as: <b>name@example.com.</b></p> | |
| <p>Update user's email. An Email should be formatted as: <b>name@example.com</b>.</p> |
Do we have any option to set the value as a code example?
Contributor
Author
There was a problem hiding this comment.
Do you mean just formatting it like inline code? It's possible with pink, but we don't use it anywhere in the Console.
Contributor
Author
|
@eldadfux, what did you mean by:
Did you mean the |
stnguyen90
force-pushed
the
feat-update-user-preferences-text
branch
from
e947eeb to
7847f96
Compare
Member
|
@stnguyen90 Sorry formatting for in the way. I meant |
Use inline code for email to indicate it's a value. Remove bolding to simplify things.
stnguyen90
force-pushed
the
feat-update-user-preferences-text
branch
from
f822bbe to
a8ad70f
Compare
eldadfux
approved these changes
Jul 28, 2023
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add description text + tweaks from Eldad.
Test Plan
Manual:
Related PRs and Issues
None
Have you read the Contributing Guidelines on issues?
Yes