fix(#430): Change success message to 'Creating Index' for better user… #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter user understanding
|
@Chaitanya-Upadhye is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
I think the message it's ok as it is WDYT @chenparnasa ? |
Contributor
|
I agree @ArmanNik, we should be consistent with the rest of the creation alerts :) |
Contributor
|
cc: @stnguyen90 |
stnguyen90
approved these changes
Aug 8, 2023
Contributor
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
LGTM! This matches what we decided to do for retrying a build:
eldadfux
approved these changes
Aug 8, 2023
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… understanding
What does this PR do?
This PR addresses issue #430. The 'Index has been created' message has been updated to 'Creating Index' to provide a more accurate description of the indexing operation's status.
Test Plan
Manual
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes