add title and description props and slots for Modal #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ArmanNik
suggested changes
Aug 22, 2023
Contributor
ArmanNik
left a comment
ArmanNik
left a comment
There was a problem hiding this comment.
We need to refactor all remaining modals introduced after this PR 😅
ArmanNik
approved these changes
Aug 22, 2023
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors Modal to allow title and description in header, just like in Pink.
I also opted to allow a prop instead of a slot, while keeping the slot as an option. The prop is autocompletable, unlike the slot, and is much simpler to write than
<svelte:fragment slot="title>. The slot should remain though IMo in cases where you want to add HTML elements rather than just text.This refactors most Modals to use the prop syntax.
Test Plan
Manual
Related PRs and Issues
Based on #479
Have you read the Contributing Guidelines on issues?
Yes