Update user labels based on design review #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-code-component-style-fix
Use `symmetricDifference` instead of `difference`. - `difference` only returns values that are present in the edited attributes, but not in the originally fetched attribute vales. This always ends up returning an empty array. - I used `symmetricDifference` as it returns an intersection of `difference` from both sides and works perfectly for this use case, as the original attributes never change.
- Original code creates a reference copy of `$doc` into `$work` which means that editing values of `$work` changes the values in `$doc`. - Fix this behaviour by creating a deep clone of `$doc` into `$work`, so underlying values aren't cross-referenced.
Instead of cramming all the steps for correct deep cloning, I split the implementation into 4 distinct steps: - define they keys to exclude - filtering the keys - reduce filtered keys into an object - returning a writable deep clone
Fix 5295 code component style fix
…document-after-array-value-deletion fixed issue that didn't allow a user to update a document when deleting elements in an array attribute
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1. Fix typo in labels placeholder 2. Reorder tags and helper text
stnguyen90
force-pushed
the
fix-user-labels-design-corrections
branch
from
8eb5f02 to
17d0594
Compare
stnguyen90
changed the title
heyCarla
suggested changes
Aug 15, 2023
Contributor
heyCarla
left a comment
heyCarla
left a comment
There was a problem hiding this comment.
Everything looks good, just one small change needed!
src/routes/console/project-[project]/auth/user-[user]/updateLabels.svelte
Show resolved
Hide resolved
heyCarla
approved these changes
Aug 16, 2023
Contributor
heyCarla
left a comment
heyCarla
left a comment
There was a problem hiding this comment.
NVM, don't know what I was thinking. I just checked the pill again and you're using the right one. All good here!
ArmanNik
approved these changes
Aug 21, 2023
…els-design-corrections
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
Visit Preview
Manual:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes