Updated Client Side Cron Regex #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KanniShashankh is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
2 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stnguyen90
previously requested changes
Sep 21, 2023
Contributor
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Great work! Please make sure the linter and tests pass.
Contributor
Author
Done with the linter test, Investigating the problem in Unit testing which incorrectly validates the tests. Will push a commit soon |
Contributor
|
@KanniShashankh there still seems to be a problem with the linter 🧐 |
KanniShashankh
force-pushed
the
bug-5719-client-cron-regex-update
branch
from
5f7eda3 to
c3faa36
Compare
Contributor
Author
|
@stnguyen90 To keep the regex simple, since this is just a frontend check, i have very much simplified the expression to match 5 segments of cron. Please let me know if i need to add something :) |
TorstenDittmann
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updated the Regex Pattern to correctly validate the cron syntax.
Mentioned the allowed values in a comment.
Test Plan
I tried a few statements and they validated correctly.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes