Fix wrong validation of projectid #571
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
requested changes
Oct 13, 2023
Contributor
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Great PR! 🤯 We left some comments during the review, please check them out.
|
|
||
| let element: HTMLInputElement; | ||
| let icon = 'info'; | ||
| const pattern = String.raw`^[a-z0-9][a-z0-9-]{1,35}$`; |
Contributor
There was a problem hiding this comment.
Something seems wrong with this pattern when it actually gets built. in the browser console logs i see:
Pattern attribute value ^[a-z0-9][a-z0-9-]{1,35}$ is not a valid regular expression: Uncaught SyntaxError: Invalid regular expression: /^[a-z0-9][a-z0-9-]{1,35}$/v: Invalid character class
And it doesn't look like the client-side validation works because the network request is sent despite the invalid id:
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
update the helper text
Test Plan
I update the CustomId component when name is project, it will use a new InputProjectId rather than InputId.
I updated the unit tests, and I verified that they all passed successfully.
before
after
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
(Write your answer here.)