Fix 6279 wrong validation of projectid #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nick2432 is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TorstenDittmann
requested changes
Oct 17, 2023
stnguyen90
reviewed
Oct 17, 2023
Contributor
TorstenDittmann
left a comment
TorstenDittmann
left a comment
There was a problem hiding this comment.
lets use some shorter syntax and we are good imo 👍🏻
src/routes/console/organization-[organization]/createProject.svelte
Outdated
Show resolved
Hide resolved
Co-authored-by: Torsten Dittmann <torsten.dittmann@googlemail.com>
Co-authored-by: Torsten Dittmann <torsten.dittmann@googlemail.com>
…velte Co-authored-by: Torsten Dittmann <torsten.dittmann@googlemail.com>
stnguyen90
requested changes
Oct 18, 2023
Contributor
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Tested and the validation works well:
The only minor recommendation is to remove the package-lock.json change.
stnguyen90
approved these changes
Oct 18, 2023
TorstenDittmann
approved these changes
Oct 18, 2023
This was referenced Nov 1, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
update the helper text
Fixes appwrite/appwrite#6279
Test Plan
I update the CustomId component when name is project, it will use a new InputProjectId rather than InputId.
I updated the unit tests, and I verified that they all passed successfully.
before
after
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
(Write your answer here.)