Skip to content

Conversation

@stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Jan 3, 2024

What does this PR do?

  • Remove provider default param
  • Remove MQTT provider as it was descoped for G1
  • Default enabled to true when creating a provider

Test Plan

Manual

Related PRs and Issues

Parent:

Child:

Have you read the Contributing Guidelines on issues?

Yes

The default param was removed from the API so it should be removed
from the Console as well.
@vercel
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 2:30pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 2:30pm
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 2:30pm

There's some code for creating a target, but it must go through design
first.
We must pass undefined because the server won't accept an empty string.
Undefined will make the server use the default value, which is an empty
string.
Don't allow filtering on userName since the attribute isn't in the
collection to be filtered.

Allow filtering on type since it is available and it would be userful.

Change $createdAt type to datetime to allow filtering by greater/less
than.
Message is nested in data and isn't an attribute so it can't be queried.
Clarify what can be searched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants