Add XDebug #20
Merged
Add XDebug #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds XDebug version 8.2.2
2 tasks
Member
|
@PineappleIOnic I am pretty sure this will cause the entire server to be slower if always enabled. Please double check |
Contributor
Author
|
It isn't always enabled, we never add the extension to the ini files. My second PR within Appwrite does that under the |
Member
|
Got it, do we have some way to test this addition under the existing tests? |
Contributor
Author
|
I'm not entirely sure what exactly to test here sorry, we could have checks that validate that xdebug_info() exists if DEBUG=true or something like that if that's what your thinking of |
abnegate
approved these changes
Nov 7, 2023
Member
|
@PineappleIOnic we can potentially test it on Appwrite. |
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds XDebug version 8.2.2