🐛 Bug Report: target vs targets

[theemaster]

👟 Reproduction steps

In main.js shouldn't line 60:

.join(target.fallback ?? target.default ?? '')

be targets instead of target?

I tried to create types because I am using TypeScript in my appwrite functions. My type definitions where:

interface TargetPrefs {
  appName?: string;
  appPath?: string;
  appPackage?: string;
  fallback?: string;
}

interface Targets {
  [platform: string]: string | TargetPrefs;
}

interface PathConfig {
  path: string;
  targets: Targets;
}

👍 Expected behavior

The platform definitions in the CONFIG examples do not contain an example where a target/platform contains a default property.

👎 Actual Behavior

Only targets have a property default which might be accessible.

🎲 Appwrite version

Version 1.4.x

💻 Operating system

Linux

🧱 Your Environment

appwrite 1.4.3

nodeJS using TypeScript

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

[stnguyen90]

@theemaster, thanks for creating this issue! 🙏🏼 Yes, it seems like target.default should be targets.default

Would you like to submit a PR?

[jaylee44]

Would love to work on this as mentioned in disc