Skip to content

Modal #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TorstenDittmann merged 2 commits into from
Jan 16, 2024
Merged

Modal #137

TorstenDittmann merged 2 commits into from
Jan 16, 2024

Conversation

@elad2412
Copy link
Contributor

@elad2412 elad2412 commented Dec 31, 2023

  • Ffx Modal-content isn't responding to overflow content
  • Add an inner wrapper to make gaps and separate it from overflow modal-content

@elad2412
Modal
5c24c7e 
- Ffx Modal-content isn't responding to overflow content
- Add inner wrapper to make gaps and separate it from overflow modal-content
@elad2412 elad2412 requested a review from ArmanNik December 31, 2023 05:28
@changeset-bot
Copy link

changeset-bot bot commented Dec 31, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: d2c83d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pink-design ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 7:30am
ui-kitchensink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 7:30am

@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
@TorstenDittmann TorstenDittmann merged commit 7580222 into main Jan 16, 2024
@TorstenDittmann TorstenDittmann deleted the modal-scroll-issue branch January 16, 2024 07:31
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

@ArmanNik ArmanNik Awaiting requested review from ArmanNik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elad2412 @TorstenDittmann