Update client.js to capture all cookies from response #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Contributor
|
Thanks for raising this PR! 🙏🏼 Unfortunately, this is a read-only repo as the code is generated by our SDK Generator, and changes made only here would be wiped in the next release. Would you be able to make the change in https://github.com/appwrite/sdk-generator/blob/master/templates/cli/lib/client.js.twig? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables appwrite-cli to capture all cookies in 'set-cookie' response headers
Test Plan
I have tested this change hosting appwrite in kubernetes environment where nginx-ingress controller adds its own cookies. And I was able to execute multiple appwrite cli commands without loggin in for each command.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes