Latest changes #21
Merged
Latest changes #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityaoberai
requested changes
Jul 4, 2023
Member
There was a problem hiding this comment.
@lohanidamodar the Readme needs some edits
Also, I can't seem to find the updated models here. Was this generated from the sdk-generator master branch? Because none of the docs examples would have HttpResponseMessage return type for our SDK's functions in that case.
README.md
Outdated
| .setSelfSigned() // Use only on dev mode with a self-signed SSL cert | ||
| ; | ||
|
|
||
| var users = Users(client); |
Member
There was a problem hiding this comment.
Suggested change
| var users = Users(client); | |
| var users = new Users(client); |
Member
There was a problem hiding this comment.
We need to fix this in Line 45 for Client() as well
README.md
Outdated
| The Appwrite .NET SDK raises `AppwriteException` object with `message`, `code` and `response` properties. You can handle any errors by catching `AppwriteException` and present the `message` to the user or handle it yourself based on the provided error information. Below is an example. | ||
|
|
||
| ```csharp | ||
| var users = Users(client); |
Member
There was a problem hiding this comment.
Suggested change
| var users = Users(client); | |
| var users = new Users(client); |
adityaoberai
approved these changes
Jul 5, 2023
Member
adityaoberai
left a comment
adityaoberai
left a comment
There was a problem hiding this comment.
@lohanidamodar the PR looks good to me 👍
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)