Dev #182
Merged
Dev #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christyjacob4
previously requested changes
Nov 16, 2023
Contributor
christyjacob4
left a comment
christyjacob4
left a comment
There was a problem hiding this comment.
changelog needs to be updated
stnguyen90
reviewed
Nov 20, 2023
| while (offset < size) { | ||
| var chunk; | ||
| final end = min(offset + CHUNK_SIZE - 1, size - 1); | ||
| final end = min(offset + CHUNK_SIZE, size); |
Contributor
There was a problem hiding this comment.
@lohanidamodar do we really want to make this change?
| List<int> chunk = []; | ||
| if (file.bytes != null) { | ||
| final end = min(offset + CHUNK_SIZE - 1, size - 1); | ||
| final end = min(offset + CHUNK_SIZE, size); |
Contributor
There was a problem hiding this comment.
@lohanidamodar do we really want to make this change?
lohanidamodar
approved these changes
Nov 20, 2023
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)