Add download tests #439
Closed
Add download tests #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abnegate
commented
May 5, 2022
abnegate
commented
- Add file download tests
Meldiron
approved these changes
May 6, 2022
# Conflicts: # tests/Android11Java11Test.php # tests/Android11Java8Test.php # tests/Android12Java11Test.php # tests/Android12Java8Test.php # tests/Android5Java11Test.php # tests/Android5Java8Test.php # tests/KotlinJava11Test.php # tests/KotlinJava17Test.php # tests/KotlinJava8Test.php # tests/PHP74Test.php # tests/PHP80Test.php # tests/Python310Test.php # tests/Python38Test.php # tests/Python39Test.php # tests/Ruby27Test.php # tests/Ruby30Test.php # tests/Ruby31Test.php # tests/SwiftClient55Test.php # tests/SwiftServer55Test.php # tests/languages/cli/test.js
lohanidamodar
requested changes
Aug 1, 2022
Member
lohanidamodar
left a comment
lohanidamodar
left a comment
There was a problem hiding this comment.
Looks good, few comments.
# Conflicts: # tests/KotlinJava11Test.php # tests/KotlinJava17Test.php # tests/KotlinJava8Test.php # tests/Ruby27Test.php # tests/Ruby30Test.php # tests/Ruby31Test.php
Member
Author
|
@christyjacob4 This one will require an update of the test instance to include this change appwrite/appwrite#3638 |
# Conflicts: # tests/Base.php # tests/languages/cli/test.js
Member
|
@abnegate can we update this with latest changes? |
Member
|
@abnegate Node is failing and also Master has updated Flutter tests that are passing please sync and fix node as well. |
Member
Author
|
@Meldiron Any thoughts on how to fix the CLI here? The endpoint returns a string but it looks like CLI hardcodes the type as |
Member
|
@abnegate seems node and deno are still failing. |
lohanidamodar
requested changes
Feb 17, 2023
Comment on lines
41
to
43
| 'GET:/v1/mock/tests/general/download:passed', | ||
| ]; | ||
|
|
Member
There was a problem hiding this comment.
Let's rename EXTENDED_GENERAL_RESPONSES to may be DOWNLOAD_RESPONSES ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.