Fix: Node exception types #553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Leaving this open until we address the consistency issue on web vs node |
TorstenDittmann
approved these changes
Oct 14, 2022
|
When these changes merge ? |
Member
|
@christyjacob4 @Meldiron can we push this forward? |
Contributor
|
@lohanidamodar yes we can 👍 I believe the web sdk has been updated to include this as well |
templates/node/index.d.ts.twig
Outdated
Comment on lines
125
to
130
| export class {{spec.title | caseUcfirst}}Exception extends Error { | ||
| public code: number; | ||
| public type: string; | ||
| public response: {{spec.title | caseUcfirst}}ExceptionResponse; | ||
|
|
||
| constructor(message: string, code?: number, type?: string, response?: {{spec.title | caseUcfirst}}ExceptionResponse); |
Contributor
There was a problem hiding this comment.
@Meldiron can we make this consistent with the web sdk ?
https://github.com/appwrite/sdk-for-web/blob/master/src/client.ts#L84-L89
Contributor
Author
There was a problem hiding this comment.
Made web, node and Deno consistent.
Don't we need to do the same for all languages?
Member
|
@Meldiron new version should have solved this right? Is this still relevant? |
Member
|
@Meldiron closing this for now, please re-open if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type definitions in Node were not in sync with actual functionality regarding exceptions.
Test Plan
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes 😊