Add label method to Role helper #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
force-pushed
the
feat-role-label
branch
2 times, most recently
from
b5d9442 to
4b9f10c
Compare
stnguyen90
force-pushed
the
feat-role-label
branch
from
4b9f10c to
9c5ab90
Compare
lohanidamodar
approved these changes
Jul 11, 2023
Member
lohanidamodar
left a comment
lohanidamodar
left a comment
There was a problem hiding this comment.
Great work, I like that we are adding comments alongside as well.
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See related issue.
Test Plan
Updated tests.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes