added pdf generate in python #217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loks0n
reviewed
Oct 6, 2023
Member
There was a problem hiding this comment.
Please rename this file to README.md
loks0n
requested changes
Oct 6, 2023
Member
loks0n
left a comment
loks0n
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Can you provide a video showing the function working.
Please note this contribution will not count towards hacktoberfest as it does not have a requisite issue.
| # with open("output.pdf", "wb") as f: | ||
| # f.write(pdf_buffer) | ||
|
|
||
| return pdf_buffer |
Member
There was a problem hiding this comment.
This won't work, we need to use res.send() with the requisite headers. Please see examples of the template in other runtimes
|
|
||
| No environment variables required. | ||
|
|
||
| > Note: Ensure you have a `requirements.txt` file in the project directory containing all the necessary packages (like `Faker`, `pdfkit`, etc.). |
Member
There was a problem hiding this comment.
Since we provide this we don't need this line :)
Member
|
Can you also please create a relevant issue for this? |
Member
|
Closing as we don't have a relevant issue for this |
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Generate PDF Template for python
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
Yes