Skip to content

Conversation

@PriyanshuPz
Copy link

What does this PR do?

This PR adds new template for Push Notification with FCM in TypeScript.

Test Plan

  1. I have deployed this Function and checked that iit is working fine.
  2. below is the demo of my work.
Functions.-.Appwrite.-.Google.Chrome.mp4

Related PRs and Issues

The issue this PR solves is #253

Have you read the Contributing Guidelines on issues?

Yes, I have read the instructions on issue #253

@PriyanshuPz
Copy link
Author

@Haimantika @loks0n Please review pull request!

@PriyanshuPz PriyanshuPz requested a review from loks0n November 23, 2023 13:58
@PriyanshuPz PriyanshuPz requested a review from loks0n November 23, 2023 14:14
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great! 🔥 Left a few comments. Once addressed, I can mark it approved.

@loks0n We can ignore README changes, they will get overwritten anyway after merge.

Copy link
Author

@PriyanshuPz PriyanshuPz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to do less changes and wrote this code as similar to node. if do futher improvement like node then it will give types errors. Please support and inform me next.

@PriyanshuPz PriyanshuPz requested a review from Meldiron November 24, 2023 12:12
@PriyanshuPz PriyanshuPz closed this by deleting the head repository Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants