Fix: email form sender #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sending form as contact emailer is fairly common. |
Contributor
Author
|
During QA I noticed it always went to spam as unauthorized. Considering it should be simple starter template, I think it's fine to take smtp username as default, and they can change it in the code if needed. |
loks0n
approved these changes
Sep 11, 2023
christyjacob4
approved these changes
Sep 11, 2023
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes behaviour of SMTP sender in HTML contact form
Test Plan
Related PRs and Issues
x
Have you read the Contributing Guidelines on issues?
Yes