📚 Documentation: Tutorial for Angular #219
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TorstenDittmann
added
the
documentation
|
@aakashraj01 Are you still working on this? |
Yes @gewenyu99 . I m still working and have done most of the review comment changes :) |
Don't forget to re-request review and make sure you build passes! |
|
Hey @gewenyu99 . I have made all the changes as per your review comments suggestions. Please have a review over the PR :) |
gewenyu99
left a comment
gewenyu99
left a comment
There was a problem hiding this comment.
Hey, there's a lot of missing and incorrect information I found and could not properly follow the tutorial.
Please carefully follow your own tutorial from scratch and make sure it works so we can accept it in time for Hacktoberfest!
| ```ts | ||
| import { Injectable } from '@angular/core'; | ||
| import { BehaviorSubject } from 'rxjs'; | ||
| import { account } from './appwrite.service'; |
| } | ||
|
|
||
| async register(email: string, password: string): Promise<void> { | ||
| await account.create(email, password); |
There was a problem hiding this comment.
This is missing arguments. account.create requires 3 arguments at minimum
| } | ||
| ``` | ||
|
|
||
| Ensure you have the FormsModule imported in your `app.module.tsx` to use `[(ngModel)]` for two-way data binding. |
There was a problem hiding this comment.
Please give more details here. Take inspiration from here:
https://appwrite.io/docs/quick-starts/angular#step-5
| - A logout button if the user is logged in. | ||
| - A login button if the user is not logged in. | ||
|
|
||
| Update the `AppComponent` in `src/app/app.component.tsx`: |
There was a problem hiding this comment.
I don't have this file. I have 3 files, are you missing setup instructions?
There was a problem hiding this comment.
Also should we really use TSX? What is the recommended default for Angular, can we stick to it?
| @Component({ | ||
| selector: 'app-root', | ||
| template: ` | ||
| <app-navbar></app-navbar> <!-- Add the navbar before page content --> |
|
Hey, Due to time constraints, I'm going to mark this PR When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag. Thanks for helping us improve Appwrite! |
|
Hello @aakashraj01 , Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback. We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions and/or ensure the tests pass by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event. Looking forward to your updates and thank you! |
|
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
Hey @gewenyu99 . My discord username is Aakash Raj#8138 |
TorstenDittmann
force-pushed
the
main
branch
5 times, most recently
from
6e3c6b4 to
83e3ebc
Compare
4 participants
What does this PR do?
Added Tutorial for a functioning app with Angular in the Docs
Test Plan
The Tutorial can be found in the route /docs/tutorials/angular/step-1
Related PRs and Issues
#81
Have you read the Contributing Guidelines on issues?
Yes