-
Notifications
You must be signed in to change notification settings - Fork 296
Feat: LFS warning #2512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: LFS warning #2512
Conversation
WalkthroughA new GitHub Actions workflow file is added at Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/lfs-warning.yml (2)
8-18: Rename job from "format" to be more descriptive.The job is named
format, which conventionally refers to code formatting workflows (e.g., Prettier, Black). However, this job performs file size checking for LFS warnings. A more descriptive name likelarge-file-checkorlfs-warning-checkwould improve clarity and prevent confusion when viewing CI status or referencing the job in other workflows.Apply this diff to improve clarity:
jobs: - format: + large-file-check: runs-on: ubuntu-latest
1-18: Consider updating to ppremk/lfs-warning@v3.3 (latest).ppremk/lfs-warning@v3.2 is a legitimate published release, but v3.3 is available. While v3.2 is functional and valid, updating to the latest version ensures access to any recent improvements or fixes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/lfs-warning.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: tests
- GitHub Check: build
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 73.1%, saving 365.7 KB.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/lfs-warning.yml (1)
21-21: Pin the action to a stable version tag, not@main.Using
@mainfor CI/CD workflows can introduce unexpected breaking changes. Specify a concrete version tag (e.g.,@v1.1.0) to ensure reproducible builds and prevent surprise failures from upstream changes.- uses: calibreapp/image-actions@main + uses: calibreapp/image-actions@v1.1.0Verify the latest stable version on the action's releases page.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
static/sample-delme.pngis excluded by!**/*.png
📒 Files selected for processing (1)
.github/workflows/lfs-warning.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/lfs-warning.yml (1)
23-31: Clarify the workflow's purpose: warning vs. automatic compression.The PR objective states "warn against large files," but this workflow is configured to compress and potentially commit changes (
compressOnly: false). Additionally, theGITHUB_TOKENis commented out, which may prevent the action from functioning as intended (e.g., posting comments or creating commits).Consider one of these approaches:
- If the goal is to warn only (not modify files): Set
compressOnly: trueand uncommentGITHUB_TOKENso the action can comment on the PR with warnings.- If the goal is to automatically compress (modify files in the PR): Uncomment
GITHUB_TOKENso the action has permission to commit changes.Which approach is intended?
|
Dont like any of directions. Ill re-understand original problem, and see how else can it be prevented |
What does this PR do?
Adds CI/CD job to warn against large files. Should help prevent uploading large pngs by mistake
Test Plan
Related PRs and Issues
x
Have you read the Contributing Guidelines on issues?
yes
Summary by CodeRabbit