Skip to content

Conversation

@stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Dec 10, 2025

What does this PR do?

This PR fixes the tables to put the contents in the right cells.

Test Plan

Manual:

localhost_5173_privacy

Related PRs and Issues

Previous privacy PRs:

Have you read the Contributing Guidelines on issues?

Yes

Summary by CodeRabbit

Release Notes

  • Documentation
    • Updated privacy policy formatting to improve readability with restructured list layouts.

✏️ Tip: You can customize this high-level summary in your review settings.

This PR fixes the tables to put the contents in the right cells.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

Walkthrough

The changes reformat bullet list entries in the privacy policy markdown documentation. Multiple sections including "Specific personal data we collect," "Third parties with whom we share your personal data," "Consent/Legal basis," and "Consequences of not providing the personal data" are restructured from flat lists to nested sub-bullet lists. All changes are purely presentational within table formatting, with no modifications to logic, control flow, or semantic content.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • The changes are repetitive, consistent formatting applied across multiple list sections
  • No logic, functionality, or exported declarations are affected
  • Changes are purely cosmetic markdown restructuring
  • Visual verification of indentation and nesting is straightforward

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing privacy policy table formatting and alignment issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-privacy-tables

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ab0d5b and 882befd.

📒 Files selected for processing (1)
  • src/routes/privacy/+page.markdoc (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: assets
  • GitHub Check: build
  • GitHub Check: tests
🔇 Additional comments (2)
src/routes/privacy/+page.markdoc (2)

37-42: LGTM — Nested bullet formatting is clean and consistent.


52-53: LGTM — Consistent nested list formatting.

Comment on lines +71 to +74
- Phone number
- Usage details
* - Full name
- Email address
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cd /repo && wc -l src/routes/privacy/+page.markdoc

Repository: appwrite/website

Length of output: 115


🏁 Script executed:

cd /repo && sed -n '60,110p' src/routes/privacy/+page.markdoc

Repository: appwrite/website

Length of output: 115


🏁 Script executed:

pwd && ls -la

Repository: appwrite/website

Length of output: 2369


🏁 Script executed:

fd "+page.markdoc" | head -20

Repository: appwrite/website

Length of output: 352


🏁 Script executed:

sed -n '60,110p' src/routes/privacy/+page.markdoc

Repository: appwrite/website

Length of output: 1712


🏁 Script executed:

cat -n src/routes/privacy/+page.markdoc | sed -n '64,107p'

Repository: appwrite/website

Length of output: 1898


Remove duplicate entries in the "Specific personal data we collect" section.

Lines 71–74 duplicate data already in the preceding cell:

  • Line 71 repeats "Phone number" from line 67
  • Lines 73–74 repeat "Full name" and "Email address" from lines 65–66

Clarify whether "Usage details" (line 72) is intentional new content or was mistakenly added during restructuring. If intentional, confirm its placement; if not, remove it along with the other duplicates.

🤖 Prompt for AI Agents
In src/routes/privacy/+page.markdoc around lines 71–74, remove the duplicate
list items ("Phone number", "Full name", "Email address") that repeat entries
already present earlier, and either delete "Usage details" if it was added
accidentally or, if it is intentional, confirm its intent and move it into the
correct section with a brief clarifying label (e.g., "Usage details (e.g., app
usage, feature interactions)") so the list has no duplicates and each item is
clearly placed.

Comment on lines +92 to 97
* - Userlist
- MSG91
- Activetrail (Israel only)
- SMS.to
* - Sentry.io
- Sentry.io
* - Userlist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# First, check if the file exists and get its content around lines 92-97
cat -n src/routes/privacy/+page.markdoc | sed -n '85,105p'

Repository: appwrite/website

Length of output: 1025


Remove duplicate "Userlist" entry on line 97.

"Userlist" appears as a separate entry on line 97 with no nested items, duplicating the entry on line 92. Remove line 97 only, retaining all nested service providers (MSG91, Activetrail, SMS.to, Sentry.io) under the first Userlist entry.

  - SMS.to
  - Sentry.io
-* - Userlist
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* - Userlist
- MSG91
- Activetrail (Israel only)
- SMS.to
* - Sentry.io
- Sentry.io
* - Userlist
* - Userlist
- MSG91
- Activetrail (Israel only)
- SMS.to
- Sentry.io
🤖 Prompt for AI Agents
In src/routes/privacy/+page.markdoc around lines 92 to 97, there is a duplicate
top-level "Userlist" entry on line 97 that should be removed; keep the original
"Userlist" entry at line 92 along with its nested items (MSG91, Activetrail,
SMS.to, Sentry.io) and delete only the redundant standalone "Userlist" line so
the list is not duplicated.

- Cannot log in using two factor authentication based on phone number
- Cannot monitor and solve errors
- Cannot sign up using our website forms
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove the empty bullet point on line 107.

Line 107 contains * with no content, which represents an empty bullet point. This appears to be a formatting artifact from the restructuring. Verify if this is intentional or a copy-paste error, and remove if unintended.

   - Cannot sign up using our website forms
-* 
{% /table %}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
*
🤖 Prompt for AI Agents
In src/routes/privacy/+page.markdoc at line 107, remove the empty bullet point
that consists solely of "* " (a lone list marker) — delete that line so there is
no stray empty list item; verify surrounding list indentation/blank lines remain
valid and run a quick markdown/markdoc render check to ensure no formatting
regressions.

@stnguyen90 stnguyen90 requested a review from DylanG-64 December 12, 2025 08:02
@stnguyen90 stnguyen90 merged commit 8d4ff61 into main Dec 12, 2025
6 checks passed
@stnguyen90 stnguyen90 deleted the fix-privacy-tables branch December 12, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants