Skip to content

feat: add aria-labels to nav elements #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TGlide merged 7 commits into from
Dec 12, 2023
Merged

feat: add aria-labels to nav elements #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
765316a
feat: add aria-labels to nav elements
CBID2 Nov 17, 2023
c95dfbe
fix: omit extra nav element
CBID2 Nov 21, 2023
c1bf420
fix: renamed aria-labels for <nav> elements
CBID2 Nov 21, 2023
d68fe6a
Merge branch 'main' into making-nav-more-accessible
CBID2 Nov 23, 2023
a7d716b
feat: add a div tag
CBID2 Nov 29, 2023
2f66780
Merge branch 'main' into making-nav-more-accessible
TGlide Dec 12, 2023
80c2230
fix sidebar
TGlide Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/components/FooterNav.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
};
</script>

<nav
<nav aria-label="Footer"
class="aw-footer-nav u-margin-block-start-100 u-position-relative"
class:aw-u-sep-block-start={!noBorder}
>
Expand Down
2 changes: 1 addition & 1 deletion src/lib/layouts/Docs.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
width="130"
/>
</a>
<nav class="aw-main-header-nav">
<nav class="aw-main-header-nav" aria-label="Top" >
<ul class="aw-main-header-nav-list">
<li class="aw-main-header-nav-item">
<a class="aw-link" href="/docs">Docs</a>
Expand Down
2 changes: 1 addition & 1 deletion src/lib/layouts/Main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@
width="130"
/>
</a>
<nav class="aw-main-header-nav">
<nav class="aw-main-header-nav" aria-label="Main">
<ul class="aw-main-header-nav-list">
{#each navLinks as { label, href }}
<li class="aw-main-header-nav-item">
Expand Down
10 changes: 7 additions & 3 deletions src/lib/layouts/Sidebar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@
}
</script>

<nav class="aw-side-nav" use:clickOutside={() => ($layoutState.showSidenav = false)}>
<nav
class="aw-side-nav"
use:clickOutside={() => ($layoutState.showSidenav = false)}
aria-label="Side"
>
<div class="aw-side-nav-wrapper">
<button
class="aw-input-text aw-is-not-desktop"
Expand Down Expand Up @@ -101,12 +105,12 @@
</button>
{/if}
<div class="aw-side-nav-mobile-footer-buttons">
<button
<a
href="https://cloud.appwrite.io/console"
class="aw-button aw-u-inline-width-100-percent-mobile"
>
<span class="text">Go to console</span>
</button>
</a>

<a
href="https://github.com/appwrite/appwrite/stargazers"
Expand Down
5 changes: 3 additions & 2 deletions src/markdoc/tags/Tabs.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
</script>

<div class="aw-card is-normal u-margin-block-start-16" {...$root} use:root>
<nav class="tabs u-flex u-gap-16">
Copy link
Contributor

@TGlide TGlide Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my wording was off here. By removing the nav element, I meant swapping it with something else, e.g. a div. Otherwise we lose the styling we had here.

<div class="tabs u-flex u-gap-16">
<ul class="tabs-list" {...$list} use:list>
{#each $ctx.triggers.entries() as [id, title]}
<li class="tabs-item">
Expand All @@ -36,9 +36,10 @@
{...$trigger(id)}
use:trigger>{title}</button
>

</li>
{/each}
</ul>
</nav>
</div>
<slot />
</div>