feat:add skip to content link #359
Conversation
|
@ketanbaitule is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
Screencast.from.2023-11-18.15-45-45.webm |
TGlide
left a comment
TGlide
left a comment
There was a problem hiding this comment.
Thank you for the PR! I left some comments, and also let our design team know about this so they can review it.
| </svelte:head> | ||
|
|
||
| <main class="aw-main-section"> | ||
| <main class="aw-main-section" id="main"> |
There was a problem hiding this comment.
Adding it to pages alone won't be enough, we should add them to all relevant layouts
src/lib/layouts/Docs.svelte
Outdated
| position: absolute; | ||
| top: 0; | ||
| -webkit-transform: translateY(-999px); | ||
| transform: translateY(-999px); |
There was a problem hiding this comment.
Wouldn't it be better to use opacity instead of translations?
|
@ketanbaitule I'm a member of the Design team at Appwrite :) |
|
@TGlide Hi I have not completed it due to my exams. I guess you have mistakenly merged it |
I've made some commits on top of your work before merging it 🙂 |
3 participants
What does this PR do?
Add Skip To Content Link
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
Solves #278
Have you read the Contributing Guidelines on issues?
Yes