Skip to content

Fix formatting & add endpoints to refereneces #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TGlide merged 8 commits into from
Dec 18, 2023
Merged

Fix formatting & add endpoints to refereneces #382

TGlide merged 8 commits into from
Dec 18, 2023

Conversation

@TGlide
Copy link
Contributor

@TGlide TGlide commented Nov 23, 2023

No description provided.

@TGlide TGlide self-assigned this Nov 23, 2023
@render
Copy link

render bot commented Nov 23, 2023

Your Render PR Server URL is https://appwrite-pr-382.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-clfofl6f27hc73a8isu0.

@vercel
Copy link

vercel bot commented Nov 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 3:19pm

TorstenDittmann
TorstenDittmann approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure it goes through a design review 👍🏻

@eldadfux
Copy link
Member

eldadfux commented Nov 23, 2023

Reminder to add some padding between the sticky top border and the path code block

@eldadfux
Copy link
Member

eldadfux commented Nov 23, 2023

We're also missing the /v1/ prefix for the paths.

gewenyu99
gewenyu99 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice <3

Maybe address should be on the left tbh, let's talk about this with Chen later.

gewenyu99
gewenyu99 suggested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TGlide Check Asana, there are some changes Chen asked for :)

@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
@gewenyu99
Copy link
Contributor

gewenyu99 commented Dec 18, 2023

image
One last comment, can we make the copy button here select only the path not the method?

Copy /getAccount vs GET /getAccount as a figurative example.

gewenyu99
gewenyu99 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comment about copy, if that's difficult/not possible right now, we can merge this as is.

@gewenyu99
Copy link
Contributor

gewenyu99 commented Dec 18, 2023

LGTM, paste is fixed

@TGlide TGlide merged commit bd282cb into main Dec 18, 2023
@github-actions github-actions bot mentioned this pull request Jan 1, 2024
Closed
@adityaoberai adityaoberai deleted the fix-formatting branch August 22, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

+1 more reviewer

@gewenyu99 gewenyu99 gewenyu99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TGlide TGlide

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TGlide @eldadfux @gewenyu99 @TorstenDittmann