Skip to content

Conversation

@wess
Copy link
Contributor

@wess wess commented Jan 5, 2024

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

wess added 2 commits January 5, 2024 10:52
Updates top nav with a check for a logged in user in order to update message accordingly
@render
Copy link

render bot commented Jan 5, 2024

@wess wess requested a review from TorstenDittmann January 5, 2024 15:56
@vercel
Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 2:02pm

<div class="aw-mobile-header-end">
{#if !$isMobileNavOpen}
<a href="https://cloud.appwrite.io" class="aw-button">
<a href="https://stage.cloud.appwrite.io" class="aw-button">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to remove stage.

}
let getAccount = async () => {
loggedIn.set(
localStorage.getItem('appwrite:loggedIn') !== null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a convention of how we store things in localstorage? do we have this documented?

@eldadfux
Copy link
Member

eldadfux commented Jan 6, 2024

@wess also, on the docs, the CTA is always Go to Console

Adds login check to CTA
@render
Copy link

render bot commented Jan 11, 2024

Adds login check to CTA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants