Skip to content

Add new AwsInstance fields. #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
UserNotFound merged 4 commits into from
Jun 14, 2022
Merged

Add new AwsInstance fields. #140

UserNotFound merged 4 commits into from
Jun 14, 2022

Conversation

@UserNotFound
Copy link
Member

@UserNotFound UserNotFound commented Jun 13, 2022

@UserNotFound UserNotFound requested a review from aguilinger June 13, 2022 20:42
@UserNotFound UserNotFound requested a review from almathew as a code owner June 13, 2022 20:42
@UserNotFound UserNotFound removed the request for review from almathew June 13, 2022 20:44
@ioquatix
Copy link

ioquatix commented Jun 14, 2022

What was the problem here?

@UserNotFound
Copy link
Member Author

UserNotFound commented Jun 14, 2022

What was the problem here?

@ioquatix We still test and rely on Ruby 2.2, and as noted in socketry/multipart-post#93, there was an unsupported method deprecate_constant added in socketry/multipart-post#91, so we have to pin to the prior release.

@UserNotFound UserNotFound merged commit 21d0f92 into master Jun 14, 2022
@UserNotFound UserNotFound deleted the instance-fields branch June 14, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aguilinger aguilinger aguilinger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@UserNotFound @ioquatix @aguilinger