fixed urlencode for repo name in /put

[theoborealis]

Fixes #1507

Description of the Change

Changes wrong comparison taking url encode into account

Checklist

• functional test added/updated (if change is functional)
• author name in AUTHORS

[neolynx]

Would this also apply to all other methods receiving a 'name' param ?

[theoborealis]

Can't say it for sure. Other methods do not have this problem at all, acting like there is no url encode, as stated in the issue

[neolynx]

@theoborealis could you wanna add your self to the AUTHORS file ?

also we should add a little system test to keep the coverage.

you could also allow edit access to the maintainers for this PR, then I can help with the testing...

[neolynx]

turns out, there is currently no test for this API call:
github.com/aptly-dev/aptly/api/repos.go:190: apiReposEdit 0.0%

hence the 0% patch coverage...

-> we should add a test in system/t12_api/repos.py ...

[neolynx]

rebased on latest master...

[codecov]

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.73%. Comparing base (7d23196) to head (fa39bca).

Files with missing lines	Patch %	Lines
api/repos.go	57.14%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1508      +/-   ##
==========================================
- Coverage   76.94%   76.73%   -0.22%     
==========================================
  Files         160      160              
  Lines       14727    14733       +6     
==========================================
- Hits        11332    11305      -27     
- Misses       2264     2296      +32     
- Partials     1131     1132       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[neolynx]

Hi @theoborealis,

I have added a test for repoEdit, coverage is up a bit :)

then I looked a bit further into the change, and think the name field from the URL is already escaped, like all the other url parameters in other functions. what was not escaped, is the optional new name to set was not escaped.

I think the current changes solve the problem, could yu give it a try and confirm ?

[neolynx]

Hi @theoborealis,

I am still not quite clear what we are fixing here..
-> the repo param in the url is properly unesaped (and escaped by the http client)
-> the json body does not need to be escaped, normal strings can be passed

could you provide an example of what is not working in details ?
the calls provided #1507 seem to work for me, even without your change...